Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to cluster console DevWorkspace object #911

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Screen.Recording.2023-08-29.at.13.02.06.mov

What issues does this PR fix or reference?

fixes eclipse-che/che#22422

@akurinnoy akurinnoy self-assigned this Aug 29, 2023
@che-bot
Copy link
Contributor

che-bot commented Aug 29, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-911

@akurinnoy
Copy link
Contributor Author

/retest

@olexii4
Copy link
Contributor

olexii4 commented Aug 31, 2023

Знімок екрана 2023-08-31 о 05 21 09

@akurinnoy I couldn't test this PR with dogfooding instance until added the next fix(local-run.sh):

export OPENSHIFT_CONSOLE_URL=$(grep -o 'OPENSHIFT_CONSOLE_URL:.*' run/.che-dashboard-pod | grep -o '\S*$')

Could you fix it?

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 31, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2023

New changes are detected. LGTM label has been removed.

@akurinnoy
Copy link
Contributor Author

@olexii4 Thanks for the suggestion, I've included it to this PR.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-911

@openshift-ci
Copy link

openshift-ci bot commented Aug 31, 2023

@akurinnoy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path 2392bec link true /test v11-dashboard-happy-path
ci/prow/v11-images 2392bec link true /test v11-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akurinnoy akurinnoy merged commit 14811c9 into main Sep 1, 2023
@akurinnoy akurinnoy deleted the edit-devworkspace branch September 1, 2023 13:41
@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/310: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/4093: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/310: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4307 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: get-sources-rhpkg-container-build_3.x/4160: FAILURE

devspaces-operator-bundle : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.x/311: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4173: FAILURE

dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a User, I want to navigate from DevWorkspace Dashboard view to OpenShift Console DevWorkspace object
5 participants